Repository navigation
Fix/6288 procedure rejection error - #6382
rohanranjan0902 wants to merge 3 commits into
Conversation
…lockworklabs#5841) When a previous test panics while compiling a module, the cache Mutex becomes poisoned. This replaces .unwrap() with .unwrap_or_else() to recover the lock, ensuring subsequent tests surface their actual underlying errors rather than failing with a cascade of generic PoisonErrors.
|
Looks good. Clanker did point out one potential issue: |
|
I checked the TypeScript SDK’s negotiated protocols: it supports v2/v3, where out-of-energy failures are sent as |
Signed-off-by: Rohan Ranjan Prasad <149056080+rohanranjan0902@users.noreply.github.com>
|
Closing in favor of #6349, which addresses the same procedure-error handling bug with a focused change and regression coverage. The additional row-decoding changes in this PR need separate review; please propose those independently if they are still needed. Thanks for the contribution! |
Description of Changes
Procedure failures were rejected as plain strings, unlike reducer failures, which reject with
Errorinstances. Wrap procedure failures inInternalErrorin both callback paths so callers get an error object with a message and stack trace, and matchers such as.rejects.toThrow(...)work.Also preserve row parsing for existing
FixedSize(0)fixtures and correct the row-offset test fixture to use a bigint.API and ABI breaking changes
No API or ABI breaking changes.
Expected complexity level and risk
1/5 — Small SDK error-handling change with regression coverage.